Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions to opensc-explorer #79

Closed
wants to merge 7 commits into from

Conversation

marschap
Copy link
Contributor

@marschap marschap commented Aug 5, 2012

Hi,

please consider pulling the following changes to opensc-explorer:

  • opensc-explorer: use standard usage() everywhere
    With the improvements of the man page, there is no need any more
    to have special cases for help texts in some functions.
  • opensc-explorer: allow longer PINs in CHANGE & UNBLOCK
    Harmonize the allowed PIN length in CHANGE & UNBLOCK with the one in VERIFY
  • opensc-explorer: convert CHANGE & UNBLOCK to sc_pin_cmd
    consistently use the new functions of the API
  • opensc-explorer: allow entering the PIN interactively
    On non-PinPad readers, allow entering the PIN interactively if it was not given as parameter
    No change for readers offering PinPad support.
  • opensc-explorer: increase allowed bytes in RANDOM
    Allow to fetch up to 256 random bytes from the card
  • opensc-explorer: show text message for 'APDU' result
    Show "success!" or "failure!" (with text error) for the APDU command.
  • opensc-explorer: allow filename-pattern as argument to 'ls'
    Make ls more similar to the unix variant - allow file namepatterns as arguments to ls

Please consider pulling them into OpenSC's staging.

Best regards
Peter

With the improvements of the man page, there is no need any more to have
local help texts for functions.
Harmonize the allowed PIN length in CHANGE & UNBLOCK with the one in VERIFY,
making sure they are large enough for OpenPGP, which allows up ro 32 characters,
and giving additional security margin for other cards.
In VERIFY, allow the user to enter the PIN unteractively if it was not given
on the command line, and if the card reader does not support PIN input.

If it was not given on the command line and the card reader supports PIN input,
then the bahaviour is unchanged: enter PIN via card reader.
Allow to fetch up to 256 random bytes from the card -
236 being the maximal value for Le in short APDUs.
Make ls more flexible and more similar to the UNIX ls.
@viktorTarasov
Copy link
Member

Your commits are applied except the 5d76124 (81695df .. 4035245).

The 5d76124 fails with Microsoft VC because of 'fnmatch.h' that do not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants