Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new commands for opensc-explorer and bugfix for iso7816 driver #32

Merged
merged 3 commits into from
May 16, 2012
Merged

new commands for opensc-explorer and bugfix for iso7816 driver #32

merged 3 commits into from
May 16, 2012

Conversation

frankmorgner
Copy link
Member

No description provided.

@LudovicRousseau
Copy link
Member

Please document the patch.

Please add the new commands to the doc/tools/opensc-explorer.1.xml manpage

@frankmorgner
Copy link
Member Author

Documentation to the new commands is useful, I agree.

Which part or which patch do you think should be documented in more detail?

@LudovicRousseau
Copy link
Member

Document what the patch does in the commit message.
At least list the new added commands.

It looks like the commit should be splitted in 2: bugfix and new commands. And of course you document what the bug was.

@frankmorgner
Copy link
Member Author

you are only looking at the descriptive text of the pull request, not the actual commits. this pull request covers three independent commits, which include a descriptive text.

@frankmorgner
Copy link
Member Author

I have prepared documentation for the new commands and will submit them with a new pull request.
See frankmorgner/OpenSC@6133112...cc7831b

@viktorTarasov
Copy link
Member

If no other objections
I'll merge this request and pull from your branch two last commits that concern the documentation.

By the way, can the PACE reader be found/bought somewhere?

@frankmorgner
Copy link
Member Author

There are currently only two readers available "Reiner SCT cyberJack RFID standard" and "Reiner SCT cyberJack RFID komfort". Both are listed in some online shops.

@viktorTarasov
Copy link
Member

Ok, thanks.

viktorTarasov added a commit that referenced this pull request May 16, 2012
@viktorTarasov
Merge pull request #32 from frankmorgner/4d9ea43ab24a2e36fc36d1be81b3…
fb1aa8e 
…414cc003786f

new commands for opensc-explorer and bugfix for iso7816 driver

-  opensc-explorer: new find command:
   tested; nice, useful feature.
- opensc-explorer: pace:
   no means to test -- accepted.
- iso driver:
  really bug, thanks.
@viktorTarasov viktorTarasov merged commit fb1aa8e into OpenSC:staging May 16, 2012
@vletoux vletoux mentioned this pull request Dec 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frankmorgner @LudovicRousseau @viktorTarasov