[pkcs11-tool] Add support for CKM_AES_CMAC_GENERAL #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-ori
force-pushed
the
trustonic_pkcs11_tool_add_aes_cmac_general
branch
from
c0c8c3e
to
2e4d490
Compare
Jakuje
reviewed
Jun 20, 2024
b-ori
force-pushed
the
trustonic_pkcs11_tool_add_aes_cmac_general
branch
from
2e4d490
to
2aa1cae
Compare
|
It does not look like the mechanism is supported in softhsm |
Jakuje
reviewed
Jun 21, 2024
b-ori
force-pushed
the
trustonic_pkcs11_tool_add_aes_cmac_general
branch
from
2aa1cae
to
918de7e
Compare
|
@Jakuje just addressed your last comment, tell me if you want me to correct anything else |
b-ori
force-pushed
the
trustonic_pkcs11_tool_add_aes_cmac_general
branch
from
918de7e
to
0edb564
Compare
b-ori
force-pushed
the
trustonic_pkcs11_tool_add_aes_cmac_general
branch
from
0edb564
to
28b1bcb
Compare
b-ori
force-pushed
the
trustonic_pkcs11_tool_add_aes_cmac_general
branch
from
28b1bcb
to
4a4ba56
Compare
Jakuje
approved these changes
Jun 24, 2024
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request adds the support for the CKM_AES_CMAC_GENERAL mechanism in pkcs11-tool.
The CK_MAC_GENERAL_PARAMS and CK_MAC_GENERAL_PARAMS_PTR data types were added as they are needed by this mechanism.
The changes were validated using the Trustonic TEE HSM.
Best regards,
Rémy