Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkcs15-jpki.c - minidriver problem with reading public key #3182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pkcs15-jpki.c - minidriver problem with reading public key #3182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
pkcs15-jpki.c - minidriver problem with reading public key 
Add SC_PKCS15_CO_FLAG_PRIVATE on "Digital Signature Public Key" and
set pubkey_obj.flags and pubkey_obj.auth_id to use the Sign KEY
so minidriver.c can request the pin before reading the public key.
Card enforces this as perspecs.

Partial fix for #3169 Only pkcs15-jpki.c is changed.

In addition to changes in #3167 that address "user_consent" using
"PinCacheAlwaysPrompt", The JPKI card forces the user to verify the Sign PIN
before the public key is read. But to use the Sign KEY,
Windows minidriver specs V7.07 says: the "CCP_CONTAINER_INFO"
contains "cbSigPublicKey" and "pbSigPublicKey"
which is needed before the key is selected.

It might be possible to add bogus information in these and
substitute the real values at a later time. But this will require
someone with a working card.

 On branch minidriver-PinCacheAlwaysPrompt
 Changes to be committed:
	modified:   libopensc/pkcs15-jpki.c

 On branch JPKI-Improvments
 Changes to be committed:
	modified:   libopensc/pkcs15-jpki.c
  • Loading branch information
@dengert
dengert committed Jun 14, 2024
commit 9ceb0e445d109cbbeb50c16998ba91d19a30847d
8 changes: 8 additions & 0 deletions src/libopensc/pkcs15-jpki.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,11 @@ sc_pkcs15emu_jpki_init(sc_pkcs15_card_t * p15card)
"User Authentication Public Key",
"Digital Signature Public Key"
};
static int jpki_pubkey_flags[2] = {
0,
SC_PKCS15_CO_FLAG_PRIVATE
};
static int jpki_pubkey_auth_id[2] = {0, 2};
struct sc_pkcs15_pubkey_info pubkey_info;
struct sc_pkcs15_object pubkey_obj;
static char const *jpki_pubkey_paths[2] = {
Expand All @@ -217,6 +222,9 @@ sc_pkcs15emu_jpki_init(sc_pkcs15_card_t * p15card)

sc_format_path(jpki_pubkey_paths[i], &pubkey_info.path);
pubkey_info.path.type = SC_PATH_TYPE_FILE_ID;
pubkey_obj.flags = jpki_pubkey_flags[i];
pubkey_obj.auth_id.len = 1;
pubkey_obj.auth_id.value[0] = jpki_pubkey_auth_id[i];

rc = sc_pkcs15emu_add_rsa_pubkey(p15card, &pubkey_obj, &pubkey_info);
if (rc < 0) {
Expand Down
Loading