Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkcs11-tool): add support for RSA OAEP encryption #3175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlexandreGonzalo
Copy link
Contributor

Hi,
In this PR, I propose to add the support for RSA OAEP for the "--encrypt" option.
The tool already supports decryption with the "--decrypt" option or both encryption and decryption with the "--test" option.
I checked the patch with the Trustonic TEE HSM.
Regards,
Alexandre.

@AlexandreGonzalo AlexandreGonzalo force-pushed the trustonic_pkcs11_rsa_oaep_encryption branch from 722db7f to a0e35c1 Compare June 11, 2024 11:52
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
src/tools/pkcs11-tool.c Show resolved Hide resolved
@AlexandreGonzalo AlexandreGonzalo force-pushed the trustonic_pkcs11_rsa_oaep_encryption branch 2 times, most recently from 04f49f8 to fec9e3b Compare June 12, 2024 09:40
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved
@AlexandreGonzalo AlexandreGonzalo force-pushed the trustonic_pkcs11_rsa_oaep_encryption branch from fec9e3b to b27acaa Compare June 12, 2024 12:19
Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Looks good. Just let us know when you will be able to verify it works.
I would like to get the tests with softhsm (likely the test-pkcs11-tool-sign-verify.sh can be adjusted), but we can live without that for now.

@AlexandreGonzalo
Copy link
Contributor Author

I just checked with our HSM and all the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants