Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix linking of opensc-notify.exe on Windows #3170

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

H5117
Copy link
Contributor

@H5117 H5117 commented Jun 3, 2024

With Visual Studio 2022 I get:

FAILED: src/tools/opensc-notify.exe src/tools/opensc-notify.pdb
"link"  /MACHINE:x64 /OUT:src/tools/opensc-notify.exe src/tools/src_tools_versioninfo-opensc-notify.rc_versioninfo-opensc-notify.res src/tools/opensc-notify.exe.p/meson-generated_.._opensc-notify-cmdline.c.obj src/tools/opensc-notify.exe.p/opensc-notify.c.obj "/release" "/nologo" "/DEBUG" "/PDB:src/tools\opensc-notify.pdb" "src/common/libcompat.a" "src/libopensc/libopensc.a" "src/common/libscdl.a" "src/scconf/libscconf.a" "src/ui/libstrings.a" "src/ui/libnotify.a" "src/pkcs15init/libpkcs15init.a" "src/sm/libsmeac.a" "src/sm/libsmiso.a" "winscard.lib" "/SUBSYSTEM:CONSOLE" "advapi32.lib" "comctl32.lib" "gdi32.lib" "shell32.lib" "shlwapi.lib" "user32.lib" "ws2_32.lib"
libnotify.a(notify.c.obj) : error LNK2005: create_invisible_window already defined in opensc-notify.c.obj
libnotify.a(notify.c.obj) : error LNK2005: WndProc already defined in opensc-notify.c.obj
src\tools\opensc-notify.exe : fatal error LNK1169: one or more multiply defined symbols found

@H5117 H5117 force-pushed the fix_duplicate branch 2 times, most recently from a5114b5 to 7a9bda6 Compare June 3, 2024 12:10
@H5117 H5117 changed the title build: fix linking with static libopensc on Windows build: fix linking of opensc-notify.exe on Windows Jun 3, 2024
@H5117 H5117 marked this pull request as ready for review June 3, 2024 14:46
@H5117 H5117 marked this pull request as draft June 3, 2024 14:57
src/ui/invisible_window.c Outdated Show resolved Hide resolved
src/tools/Makefile.am Outdated Show resolved Hide resolved
src/ui/invisible_window.h Outdated Show resolved Hide resolved
@H5117 H5117 marked this pull request as ready for review June 4, 2024 11:30
@frankmorgner frankmorgner merged commit 81e5d54 into OpenSC:master Jun 12, 2024
41 of 45 checks passed
@H5117 H5117 deleted the fix_duplicate branch June 13, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants