Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIV: disable status requests if logged in #3163

Closed
wants to merge 1 commit into from

Conversation

frankmorgner
Copy link
Member

TODO
That being said, the conditions for this special treatment should be refined to something like IF logged in with "PIN Always"/"OCC Always" THEN avoid unnecessary APDUs. Also, the logged-in-state should be reset in this case if some APDU was sent - in best case the signature APDU, in worst case some other APDU that cannot be avoided. This refinement should also applied to the existing code referenced above, I think.

fixes #3159

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

TODO
That being said, the conditions for this special treatment should be
refined to something like IF logged in with "PIN Always"/"OCC Always"
THEN avoid unnecessary APDUs. Also, the logged-in-state should be reset
in this case if some APDU was sent - in best case the signature APDU, in
worst case some other APDU that cannot be avoided. This refinement
should also applied to the existing code referenced above, I think.

fixes OpenSC#3159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSC Minidriver with PIVApplet + ECC keys on Win11: error on slot 9c - public key does not match private key
1 participant