PIV: disable status requests if logged in #3163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO That being said, the conditions for this special treatment should be refined to something like IF logged in with "PIN Always"/"OCC Always" THEN avoid unnecessary APDUs. Also, the logged-in-state should be reset in this case if some APDU was sent - in best case the signature APDU, in worst case some other APDU that cannot be avoided. This refinement should also applied to the existing code referenced above, I think. fixes OpenSC#3159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
That being said, the conditions for this special treatment should be refined to something like IF logged in with "PIN Always"/"OCC Always" THEN avoid unnecessary APDUs. Also, the logged-in-state should be reset in this case if some APDU was sent - in best case the signature APDU, in worst case some other APDU that cannot be avoided. This refinement should also applied to the existing code referenced above, I think.
fixes #3159
Checklist