Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X25519 improvements 2 in PKCS11-tool, PKCS15 routines and tools and openpgp #3090

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

X25519 improvements 2 in PKCS11-tool, PKCS15 routines and tools and openpgp #3090

Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
dcc7346
pkcs11-tool.c - fix tag len in OID
dengert Dec 8, 2023
c060f7d
pkcs11-tool.c - Incorrect OID for edwards25519
dengert Dec 9, 2023
d85b52c
pkcs11-tool.c - CKK_GENERIC_SECRET do not have CKA_ENCRYPT or CKA_DEC…
dengert Dec 8, 2023
43d58d4
pkcs11-tool.c Add derive key support for CKK_MONTGOMERY
dengert Dec 9, 2023
a633845
pkcs11-tool.c - Update EC type curves
dengert Dec 10, 2023
584e7cc
pkcs11-tool.c - EVP_KEY_X448 not defined in LibreSSL
dengert Jan 21, 2024
2a63099
pkcs11-tool.c calculate size in bits for eddsa and xeddsa CKA_EC_POINT
dengert Jan 21, 2024
f8ce754
pkcs11-tool.c - EC_POINT DER in BIT STRING or OCTET STRING
dengert Jan 29, 2024
f83208b
pkcs11-tool.c - remore wrap/unwrap from template
dengert Apr 17, 2024
556c0cc
pkcs15.h - PKCS11 ecparams are used by CKK_EC, CKK_EDWARDS and CKK_MO…
dengert Dec 9, 2023
e8bbf37
pkcs15-prkey.c pkcs15-pubkey.c - Use common EC params
dengert Dec 9, 2023
732eda2
card-openpgp.c - Use common "ec_pointQ" for EC, EDDSA and XEDDSA
dengert Dec 9, 2023
c9e1de3
pkcs15init/pkcs15-lib.c pkcs15init/pkcs15-openpgp.c - EDDSA and XEDDSA
dengert Dec 10, 2023
a1c1fb6
card-openpgp.c - add SC_ALGORITHM_ONBOARD_KEY_GEN
dengert Dec 10, 2023
ad86f56
pkcs15-pubkey.c update ec curves and map printable strings
dengert Dec 10, 2023
61df246
pkcs15-init.c squash adding additional if statement
dengert Jan 21, 2024
b428eb0
pkcs15-algo.c - add Ed448, X448 and openpgp oids
dengert Jan 15, 2024
5fe507f
OpenPGP - Move mapping of OpenPGP specifix OIDs
dengert Jan 15, 2024
1c8bff8
pkcs15init/pkcs15-opensc.c unused variable
dengert Jan 15, 2024
82b7213
tools/pkcs15-init.c accept and case and convert to correct case
dengert Jan 20, 2024
80effc1
card-openpgp.c card-openpgp.h
dengert Jan 20, 2024
fba9f26
doc/tools/pkcs15-init.1.xml document Curve names for eddsa and xeddsa
dengert Jan 21, 2024
3042e6b
framework-pkcs15.c - Support CKA_PUBKEY_KEY_INFO
dengert Jan 28, 2024
491977c
WIP to accept pkcs11 ec_point encoded in bit string or byte string
dengert Feb 9, 2024
70d2496
pkcs15-pubkey.c make default for CKA_EC_POINT to return old OCTET S…
dengert Feb 16, 2024
1493774
test-oseid.sh use restart-pcscd.sh
dengert Feb 16, 2024
7e84589
Revert "test-oseid.sh use restart-pcscd.sh"
dengert Mar 28, 2024
a4543d4
pkcs15-pubkey.c fix bug found by fuzzer
dengert Mar 28, 2024
58ccef4
pkcs15-pubkey.c - no need to test if key is null before free
dengert Mar 28, 2024
a4265fd
pkcs15-pubkey.c - comments, whitespace and code style
dengert Mar 30, 2024
e0800ed
card-openpgp.c - whitespace and code style
dengert Mar 30, 2024
4d454fc
framework-pkcs15,c - whitespace and code style
dengert Mar 30, 2024
19b56b3
pkcs15-alg.c whitespace and code style
dengert Mar 30, 2024
7f5931e
pkcs15-init.c whitespace and code style
dengert Mar 30, 2024
2dfbe4d
files.html, tools.html - rebuild
dengert Mar 30, 2024
95696f0
pkcs15-pubkey.c - readability of mapped_string
dengert Apr 17, 2024
57c1f6f
card-openpgp.c - renove TODO comments as code was added
dengert Apr 18, 2024
a45ab3e
pkcs15-algo.c - removed comments and added asn1 calls
dengert Apr 18, 2024
064b805
pkcs15-prkey.c - moved comment
dengert Apr 18, 2024
30ec795
pkcs11-tool.c - formating
dengert Apr 19, 2024
8ef8507
pkcs15-pubkey.c - Use sc_asn1_read_tag for printable string
dengert Apr 21, 2024
64a7100
pkcs15-pubkey.c opensc.h - Add SC_ALGORITHM_* to ec_curve_info
dengert Apr 22, 2024
2009bfc
card-openpgp.c card-openpgp.h - Add SC_ALGORITHM_* to ec_curves_open…
dengert Apr 22, 2024
fc7c6d2
card.c - when adding an EC type alg call sc_pkcs15_fix_ec_parameters
dengert Apr 23, 2024
818d26a
pkcs15-pubkey.c - FIXUP order of key_type in sc_curve_info
dengert Apr 23, 2024
be1e3d9
card.c - fix bug in sc_copy_ec_params
dengert Apr 23, 2024
17834c5
pkcs15init/pkcs15-openpgp.c - test id and ec type keys
dengert Apr 24, 2024
97a8d3a
card.c when copying sc_ec_parameters get new key_type too
dengert Apr 24, 2024
9c7c398
pkcs15init/pkcs15-openpgp.c - set key_info.algorithm so EDDSA and XE…
dengert Apr 24, 2024
9b1d102
card-openpgp.c - fix invalid read found by valgrind
dengert Apr 26, 2024
951567b
pkcs15init/pkcs15-lib.c - fix double free
dengert Apr 27, 2024
8f55e45
cardctl.h - add key_type as SC_ALGORITHM_* to sc_cardctl_openpgp_keyg…
dengert Apr 28, 2024
d8546f2
opensc.h - add
dengert May 16, 2024
8550203
opensc.h - add sc_clear_ec_params
dengert May 16, 2024
bb099fb
pkcs11-tool.c - CKK_EC_EDWARDS and CKK_EC_MONTGOMERY improvements
dengert May 16, 2024
5df6fc8
card.c - add sc_clear_ec_params expand sc_card_find_alg
dengert May 16, 2024
3215bcf
pkcs15init/pkcs15-lib.c - Changes for sc_clear_ec_params
dengert May 16, 2024
4856c56
card-openpgp.c pkcs15init/pkcs15-openpgp.c - fixes
dengert May 16, 2024
42b82bf
libopensc.exports - export sc_clear_ec_params
dengert May 16, 2024
d0da85d
framework-pkcs15.c - added support for more 448 size keys
dengert May 16, 2024
1f2ada9
pkcs15-isoApplet.c - use sc_clear_ec_params
dengert May 16, 2024
3fa1d48
pkcs15-algo.c, pkcs15-prkey.c and pkcs15-pubkey.c
dengert May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
pkcs15-prkey.c - moved comment 
 On branch X25519-improvements-2
 Changes to be committed:
	modified:   libopensc/pkcs15-prkey.c
  • Loading branch information
@dengert
dengert committed May 17, 2024
commit 064b8055c4d23a0c0693b5ec7cad13fdd11d1327
3 changes: 2 additions & 1 deletion src/libopensc/pkcs15-prkey.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,8 @@ sc_pkcs15_erase_prkey(struct sc_pkcs15_prkey *key)
case SC_ALGORITHM_GOSTR3410:
free(key->u.gostr3410.d.data);
break;
case SC_ALGORITHM_EC: /* EC, Edwards and Montgomery use common ec params */
case SC_ALGORITHM_EC:
/* EC, Edwards and Montgomery use common ec params */
free(key->u.ec.params.der.value);
free(key->u.ec.params.named_curve);
free(key->u.ec.privateD.data);
Expand Down