Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkcs15-prkey.c: correctly check for presence of ECC parameters #3033

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

hamarituc
Copy link
Contributor

@hamarituc hamarituc commented Feb 16, 2024

This PR changes the condition to check for special handling of Slovakian Slovenian eID more general. Previous the existence of such parameters was tested if the values are still have their default value. Now existence is tested by parser specific flags. At least it solves #3031. But I don't have access to a Slovakian eID, but it should be checked against such a device.

Mentioning @llogar and @jurajsarinay as they were involved in the implementation of that driver and asking them kindly to check against their hardware.

closes #3031

Checklist
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Checking this works for SKeID would be helpful.

@jurajsarinay
Copy link
Contributor

handling of Slovakian Slovenian eID

This does not affect skeid (RSA only),
might affect the Slovenian eOI by @llogar.

Checking this works for SKeID would be helpful

I have checked my card works. Checking this works for eOI would be helpful.

@llogar
Copy link
Contributor

llogar commented Feb 19, 2024

eOI still works with this PR...

@Jakuje Jakuje added this to In progress in OpenSC 0.25.0 via automation Feb 19, 2024
@Jakuje
Copy link
Member

Jakuje commented Feb 19, 2024

Thank you for verification! Then I think we are good to merge this for the upcoming release.

@Jakuje Jakuje merged commit ba6e078 into OpenSC:master Feb 21, 2024
44 checks passed
OpenSC 0.25.0 automation moved this from In progress to Done Feb 21, 2024
@hamarituc hamarituc deleted the ecc branch February 21, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Private Key Objects of D-TRUST Card 4.1 Multi ECC 2 are not regcognized
5 participants