Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.25.0-rc1 #3028

Merged
merged 2 commits into from
Feb 17, 2024
Merged

0.25.0-rc1 #3028

merged 2 commits into from
Feb 17, 2024

Conversation

xhanulik
Copy link
Contributor

Related #3017

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@Jakuje Jakuje added this to In progress in OpenSC 0.25.0 via automation Feb 15, 2024
@xhanulik xhanulik mentioned this pull request Feb 15, 2024
Merged
3 tasks
frankmorgner
frankmorgner requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@frankmorgner frankmorgner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

pkcs11-tool.c:7278:74: error: implicit conversion loses integer precision: 'CK_ULONG' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
 7278 |         for (j = 0; find_object(sess, CKO_PRIVATE_KEY, &privKeyObject, NULL, 0, j); j++) {
      |                     ~~~~~~~~~~~                                                 ^

@frankmorgner frankmorgner merged commit 2361870 into OpenSC:master Feb 17, 2024
43 of 44 checks passed
OpenSC 0.25.0 automation moved this from In progress to Done Feb 17, 2024
@xhanulik xhanulik deleted the release-0.25.0 branch March 5, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankmorgner frankmorgner frankmorgner requested changes

@Jakuje Jakuje Jakuje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OpenSC 0.25.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xhanulik @frankmorgner @Jakuje