fixed type conversion #2982
Closed
fixed type conversion #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
reviewed
Jan 15, 2024
| @@ -526,7 +526,7 @@ static CK_RV gostr3410_verify_data(const CK_BYTE_PTR pubkey, CK_ULONG pubkey_len | |||
| if (!(buf = malloc(buf_len))) | |||
| r = -1; | |||
| if (r == 1 && P) | |||
| r = EC_POINT_point2oct(group, P, POINT_CONVERSION_COMPRESSED, buf, buf_len, NULL); | |||
| buf_len = EC_POINT_point2oct(group, P, POINT_CONVERSION_COMPRESSED, buf, buf_len, NULL); | |||
There was a problem hiding this comment.
this assumes this call EC_POINT_point2oct() can not fail. I think the return value 0 should be checked before continuing to the next operation (but this was an issue with the old code too and it is actually an issue with the previous call too, which would result in malloc(0)).
In any case as I mentioned in #2982 I am afraid there will be much more issues like this.
|
closing this in favor of #2993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2967
Checklist