Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Heap-use-after-free in iasecc_delete_file #2981

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

popovec
Copy link
Member

@popovec popovec commented Jan 12, 2024

Patch 773fcc6 unfortunately introduced a new bug. Here is a fix for both the old and the new bug.

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65562
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65684

Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely missed that the sc_file_get_acl_entry() keeps reference to file.

@popovec
Copy link
Member Author

popovec commented Jan 12, 2024

I didn't notice it, I apologize. The card->cache issue was distracting me.

@Jakuje Jakuje merged commit c354501 into OpenSC:master Jan 15, 2024
36 checks passed
@Jakuje
Copy link
Member

Jakuje commented Jan 15, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants