Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkcs11: use secure memory for puk if configured for `init_pin_in_so_s… #2906

Merged
merged 1 commit into from
Nov 6, 2023
Merged

pkcs11: use secure memory for puk if configured for `init_pin_in_so_s… #2906

merged 1 commit into from
Nov 6, 2023

Conversation

frankmorgner
Copy link
Member

…ession`

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

Jakuje
Jakuje approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Do you want this for the 0.24.0? I do not see a reason why it should not be there, but rather checking anyway.

@frankmorgner
Copy link
Member Author

as you prefer. I think it can be included in 0.24.0

@Jakuje Jakuje added this to In progress in OpenSC 0.24.0 via automation Nov 6, 2023
@Jakuje
Copy link
Member

Jakuje commented Nov 6, 2023

I think it would be better merged earlier to get it tested rather than later. It should be not cause any issues though. Merging then. Thank you!

@Jakuje Jakuje merged commit f55221a into OpenSC:master Nov 6, 2023
36 checks passed
OpenSC 0.24.0 automation moved this from In progress to Done Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakuje Jakuje Jakuje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OpenSC 0.24.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frankmorgner @Jakuje