Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Enable MSI signing via Signpath CI integration #2799

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

frankmorgner
Copy link
Member

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@frankmorgner frankmorgner marked this pull request as ready for review February 11, 2024 09:02
@frankmorgner
Copy link
Member Author

release signing via signpath is working now

@Jakuje
Copy link
Member

Jakuje commented Feb 13, 2024

This is good to go or is there still something that needs to be done before the release here? If not, please merge it so we can test it all works well before rc.

@frankmorgner
Copy link
Member Author

From my point of view this is good to go. signing requests are all triggered. Me and you are allowed to confirm the signing. When signed, binaries can be downloaded from signpath.io and uploaded to github releases.

@Jakuje
Copy link
Member

Jakuje commented Feb 13, 2024

Thank you. Can you update the process for confirming signing and downloading the signed tarballs in the wiki?

https://github.com/OpenSC/OpenSC/wiki/OpenSC-Release-Howto

I saw the invitation, but forgot to click the the join. Now I can see the dashboard and signing requests.

@frankmorgner
Copy link
Member Author

done

@frankmorgner frankmorgner merged commit d01ee3d into master Feb 13, 2024
41 of 43 checks passed
OpenSC 0.25.0 automation moved this from To do to Done Feb 13, 2024
@frankmorgner frankmorgner deleted the signpath branch February 28, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants