Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkcs11-tool): testing HMAC #2643

Merged
merged 4 commits into from
Nov 17, 2022
Merged

feat(pkcs11-tool): testing HMAC #2643

merged 4 commits into from
Nov 17, 2022

Conversation

AlexandreGonzalo
Copy link
Contributor

Hi All,

I wanted to test HMAC signature and verification with the new version of the pkc11-tool and I found several issues.

  • We need to add MF_GENERIC_HMAC_FLAGS for CKM_MD5_HMAC
  • We need --usage-sign for secret keys involved in HMAC operations
  • It would be great if we can add the CKM_SHA3_XXX_HMAC mechanisms definitions.
Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@Jakuje
Copy link
Member

Jakuje commented Nov 17, 2022

Thank you for your contribution!

@Jakuje Jakuje added this to In progress in Release 0.23.0 via automation Nov 17, 2022
@Jakuje Jakuje merged commit 454d8b5 into OpenSC:master Nov 17, 2022
Release 0.23.0 automation moved this from In progress to Done Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankmorgner frankmorgner frankmorgner approved these changes

@Jakuje Jakuje Jakuje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 0.23.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexandreGonzalo @Jakuje @frankmorgner