Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkcs11-tool): print serial number when reading certificates #2641

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

AlexandreGonzalo
Copy link
Contributor

I am using the pkcs11-tool to list the certificates stored in my PKCS#11 token.
I have this patch which displays the certificate serial number and maybe that's something which could be merged to master.

Certificate Object; type = X.509 cert
subject: DN: C=FR, ST=PACA, L=Valbonne, O=Trustonic, CN=*.trustonic.com
serial: 54E67E7F3DB8F07D11D473717C71E057FD7D22C9
ID: 01

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@Jakuje
Copy link
Member

Jakuje commented Nov 14, 2022

From answer to @frankmorgner comment in #2630

can we do this without being dependant on OpenSSL?

I did the same as getSUBJECT() above and it is an easy win.
I don't think that it is worth to try to avoid OpenSSL.

I think this is ok as we already use the openssl to parse the SUBJECT. In any case, most of the builds are using OpenSSL anyway now.

I think this is good to go also for 0.23.0

@Jakuje Jakuje added this to In progress in Release 0.23.0 via automation Nov 14, 2022
@Jakuje
Copy link
Member

Jakuje commented Nov 14, 2022

Thank you. Merging.

@Jakuje Jakuje merged commit 2ea0fe4 into OpenSC:master Nov 14, 2022
Release 0.23.0 automation moved this from In progress to Done Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants