Removed dead code #253
Removed dead code #253
Conversation
|
+1 |
|
It can be done for the common part, but I prefer to not touch it in the card-specific one. |
|
It all should be removed, it's dead weight. Why was this code disabled? Is it full of bugs? Was it added for debugging purposes? Is it only applied to special cards? Only the person who disabled the code knows. For all the other people dead code gets in the way of understanding things. What about asking on the mailing list for objections? And if there are any there is almost always a better solution than using "if 0". Do you know what's the best part of deleting this code? It doesn't break anything! |
|
I always considered that card-specific part is a 'private garden' of card driver maintainer. |
|
The argument of a card-specific maintainer would only apply if they all had any. They don't, thus action must be made. And if there is someone who wants to step up with such capability, he/she better be able to explain the need for dead code (does not exist) |
card-asepcos: removed dead code card-authentic: removed dead code card-belpic: removed dead code card-epass2003: removed dead code card-flex: removed dead code card-gpk: removed dead code card-oberthur: removed dead code card-piv: removed dead code card-setcos: removed dead code ctbcs: removed dead code cwa14890: removed dead code muscle: removed dead code pkcs15-atrust-acos: removed dead code pkcs15-gemsafeV1: removed dead code pkcs15-skey: removed dead code reader-ctapi: removed dead code framework-pkcs15: removed dead code pkcs11-object: removed dead code pkcs15-asepcos: removed dead code pkcs15-cardos: removed dead code pkcs15-jcop: removed dead code pkcs15-lib: removed dead code pkcs15-oberthur: removed dead code parse: removed dead code sclex: removed dead code sm-card-authentic: removed dead code sm-card-iasecc: removed dead code sm-cwa14890: removed dead code sm-global-platform: removed dead code sc-test: removed dead code pkcs11-tool: removed dead code pkcs15-tool: removed dead code
|
Applied in 5d6c4b3, |
Cleaned up all
#if 0's.Note that if the unused code should be needed some day it can still be found in the repositories history.