PIV: Fixed detection of PIV AID via empty discovery #2441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using the discovery object to detect whether it's a proper PIV application, `piv_parse_discovery()` should not return SC_SUCCESS on empty files or on files with *some* ASN.1 structure... Instead, at least the encoding of the PIV AID should be strictly according NIST SP 800-73-4
|
This was in #2053 |
|
Well, partially. |
Jakuje
requested changes
Nov 18, 2021
| if (SC_SUCCESS != sc_asn1_read_tag(&body, rbuflen, &cla, &tag, &body_len) | ||
| || cla+tag != 0x7E | ||
| || NULL == (aid = sc_asn1_find_tag(card->ctx, body, body_len, 0x4F, &aid_len)) | ||
| || aid_len < piv_aid.len || memcmp(aid, piv_aid.value, piv_aid.len) != 0) |
There was a problem hiding this comment.
First of all, this fails to build:
card-piv.c:2588:17: error: use of undeclared identifier 'piv_aid'
|| aid_len < piv_aid.len || memcmp(aid, piv_aid.value, piv_aid.len) != 0)
^
card-piv.c:2588:44: error: use of undeclared identifier 'piv_aid'
|| aid_len < piv_aid.len || memcmp(aid, piv_aid.value, piv_aid.len) != 0)
^
card-piv.c:2588:59: error: use of undeclared identifier 'piv_aid'
|| aid_len < piv_aid.len || memcmp(aid, piv_aid.value, piv_aid.len) != 0)
|
I'll open a unified draft PR with all simplifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using the discovery object to detect whether it's a proper
PIV application,
piv_parse_discovery()should not return SC_SUCCESS onempty files or on files with some ASN.1 structure... Instead, at least
the encoding of the PIV AID should be strictly according NIST SP 800-73-4
Checklist