Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itacns: fixed length checking #2118

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Conversation

frankmorgner
Copy link
Member

fixes https://oss-fuzz.com/testcase-detail/5116660103774208

I hope this is not breaking anything.

I think the correct solution would rather be to use an ASN.1 parser.

Could someone familiar with the itacns have a look, please? @nunojpg

Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

I am trying to add the links to the chromium issue tracker, which becomes public after the embargo expires, rather than to the oss-fuzz testcase, which will stay private forever (if I understand right). Could you add this too?

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25935

@frankmorgner
Copy link
Member Author

I was not aware. sure, I can do.

@frankmorgner frankmorgner merged commit 3ebfb01 into OpenSC:master Sep 29, 2020
@frankmorgner frankmorgner deleted the hextoint branch June 21, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants