sc_decompress_zlib_alloc: check inputs, avoid int underflow #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- turns out, you can shrink a buffer with realloc on some implementations - realloc is never called with 0 (which would free the data) - length checking is done in zlib, we just do the allocation closes OpenSC#1905
Jakuje
reviewed
Jan 20, 2020
src/libopensc/compression.c
Outdated
| } | ||
| if(err == Z_STREAM_END) { | ||
| if (err == Z_STREAM_END) { | ||
| if (*outLen) { |
There was a problem hiding this comment.
I would rewrite this condition to if (*outLen > 0) { for readability.
|
I think I'll leave it with this simple fix. If someone wants to rewrite this to something more sophisticated, please make a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1905
Checklist