EstEID 2018+ driver #1635
EstEID 2018+ driver #1635
Conversation
It has been some time since I wrote C so my setup has changed. Using VS Code with clang-format seems pretty neat. Maybe we can add necessary tooling/config into the source tree so that code formatting would be automated with a tool (like clang-format) ? I'll keep using the default formatting of VScode+clang-format plugin until the PR is non-draft or until I figure out how to configure clang-format in a suitable way. |
martinpaljak
force-pushed
the
esteid-2018
branch
from
57fd7f9
to
ccfc805
Compare
The way of achieving unified code style in OpenSC or recommendations thereof is still a todo. Sure, you can postpone a (somewhat) unified style for later. |
martinpaljak
force-pushed
the
esteid-2018
branch
2 times, most recently
from
2ffdf7c
to
20526ae
Compare
src/libopensc/card-esteid2018.c
Outdated
|
|
||
| static int esteid_select_file(struct sc_card *card, const struct sc_path *in_path, struct sc_file **file_out) { | ||
| unsigned char pathbuf[SC_MAX_PATH_SIZE], *path = pathbuf; | ||
| int pathlen; |
src/libopensc/card-esteid2018.c
Outdated
| LOG_TEST_RET(card->ctx, sc_transmit_apdu(card, &apdu), "APDU transmit failed"); | ||
| LOG_TEST_RET(card->ctx, sc_check_sw(card, apdu.sw1, apdu.sw2), "PSO CDS/INTERNAL AUTHENTICATE failed"); | ||
|
|
||
| LOG_FUNC_RETURN(card->ctx, apdu.resplen); |
martinpaljak
force-pushed
the
esteid-2018
branch
from
9028627
to
31cb527
Compare
martinpaljak
requested review from
frankmorgner
and removed request for
frankmorgner
|
please also look at the two unresolved comments above |
There was a problem hiding this comment.
See comment above. There is also this remark. Please exclude .clang-format from this PR.
The rest looks good.
martinpaljak
force-pushed
the
esteid-2018
branch
from
b3bc2ca
to
26d4e98
Compare
Addressed both, removed clang-format, rebased on master. |
| struct esteid_priv_data *priv; | ||
| struct sc_apdu apdu; | ||
|
|
||
| // XXX: could be const |
There was a problem hiding this comment.
Why not make it const then?
This adds support for a minimalistic, small and fast card profile based on IAS-ECC. Based on information from https://installer.id.ee/media/id2019/TD-ID1-Chip-App.pdf and proprietary driver snoops. Thanks to @metsma and @frankmorgner. Change-Id: I2e4b4914d8a3b991d9a639728695abf4a2362ca0
and make sure the card is always handled emulated card first Change-Id: I60174c2793bb882fb73716f62a652d84e028382c
Change-Id: I5d4d3103692fc6db51f13fc5338360289c26af9a
Change-Id: I9aa97c8a9878dddd3e6f1a2baa877d188b9d7fe5
This adds card driver for Estonian eID from 2018 onwards.
Next iteration will merge pkcs15-esteid and get rid of Estonia related stuff in card-mcrd.c