Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues discussed previously #144

Closed
wants to merge 7 commits into from
Closed

Fixed issues discussed previously #144

wants to merge 7 commits into from

Conversation

entersafe
Copy link
Contributor

Dear Sir/Madam,

Can one gatekeeper review this patch?

Regards

LudovicRousseau and others added 6 commits December 10, 2012 02:12
@LudovicRousseau
Merge pull request OpenSC#110 from tkil/trivial-fix-global-var-init-2…
f6db919 
…0121209

pkcs15-tool: initialize 'opt_auth_id' consistently.
@entersafe
1.modify xxx_pin_cmd() return infomation while verifying and unblocki…
00ea27c 
…ng with a error pin 2.Force the xxx_pin_cmd() returned with the tries_left while a failure authentication occurred 3.Modified author contact infomation
@entersafe
check factor is padded with zero or not
1aefadf
recover copyright info
528986c
recover the log output when external key auth failed
ba87992
@entersafe
add a short comment for Why external_key_auth function returned SC_ER…
4d04003 
…ROR_PIN_CODE_INCORRECT
@entersafe
Copy link
Contributor Author

@martinpaljak Could you please review the patches . we had finished all issues discussed previously

Thank you

Regards

@JenkinsForOpenSC
Copy link

Can one of the admins verify this patch?

@viktorTarasov
Copy link
Member

@JenkinsForOpenSC ok to test

@entersafe
Copy link
Contributor Author

@martinpaljak
Hi .
Did the patch merge to branch master ?

@JenkinsForOpenSC
Copy link

Can one of the admins verify this patch?

@entersafe
Copy link
Contributor Author

@OpenSC
Hi All, want to check with you, did our new patch merge to branch master??

I saw the message "Good to merge", but the we checked the source code in branch master, they are still old one!!

Please, can anyone help to check asap!

Thanks,

@entersafe
Copy link
Contributor Author

@viktorTarasov @LudovicRousseau @martinpaljak
Hi All, want to check with you, did our new patch merge to branch master??

I saw the message "Good to merge", but the we checked the source code in branch master, they are still old one!!

Please, can anyone help to check asap!

Thanks,

@entersafe
Copy link
Contributor Author

Can anyone verify this please? It has been pending for a long time!

Thanks

@viktorTarasov
Copy link
Member

Thanks, applied in c02f30a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@entersafe @JenkinsForOpenSC @viktorTarasov @LudovicRousseau