openpgp-tool extensions & fixes #1363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* accept flexible option arguguments: 1-4, 101-104, 0101-0104, ...
frankmorgner
requested changes
May 23, 2018
| static char *prettify_serialnumber(void *ptr); | ||
| static char *prettify_name(void *ptr); | ||
| static char *prettify_language(void *ptr); | ||
| static char *prettify_gender(void *ptr); |
There was a problem hiding this comment.
I don't understand why you're removing explicit typing and use void *ptr instead. I don't see a real advantage and I fear this could lead to more problems.
| char *(*prettify_value)(char *); | ||
| enum code_types type; | ||
| size_t offset; | ||
| size_t length; /* 0 <=> potentially infinite */ |
There was a problem hiding this comment.
who is doing the length check?
| @@ -216,28 +312,87 @@ static char *prettify_gender(char *str) | |||
| } | |||
|
|
|||
|
|
|||
| static void display_data(const struct ef_name_map *mapping, char *value) | |||
| static char *bin_to_hex(char *str, const u8 *data, size_t count, int indent) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the attached commits fix a few annoyances in openpgp-tool and a new option --card-info to display information on the card.
It has been tested with
Checklist