Some cards may return RSA signatures without leading zero bytes Fixes #1283 #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very preliminary test shows that this PR works with OpenPGP 2.0 (YubiKey NEO) and 2.1 (YubiKey 4). |
|
The fix for #1283 did not return the new length. 0674dfe adds I can squash after https://github.com/MSoegtrop tests with failing card. |
frankmorgner
requested changes
Jul 4, 2018
src/libopensc/pkcs15-sec.c
Outdated
| /* Some cards may return RSA signature as integer without leading zero bytes */ | ||
| /* Already know outlen >= modlen and r >= 0 */ | ||
| tmpoutlen = r; | ||
| if (obj->type == SC_PKCS15_TYPE_PRKEY_RSA && tmpoutlen < modlen) { |
There was a problem hiding this comment.
please fix the indenting and rewrite the code so that tmpoutlen is not needed.
|
What's the testing status, @MSoegtrop? |
Add leading zeros to RSA signature so it is the size of modulus. Return modulus length. Changes to be committed: modified: src/libopensc/pkcs15-sec.c
|
Removed @MSoegtrop This still needs to be tested using a card that has this problem. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add leading zero bytes in a signature so it is the size of modulus.
Fixes #1283
On branch short-signatures
Changes to be committed:
modified: libopensc/pkcs15-sec.c
Checklist