Improve code and fix sign bugs #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In epass2003_set_security_env, remove unused code, add condition check of ec and rsa 2. Line 1709 - add return check of hash_data 3. In epass2003_decipher API, the old sign using apdu.le = 256, now add condition check of rsa 4. Line 2731-2734 - After login successful, need get session status, adjust code, improve condition check of data->cmd.
frankmorgner
requested changes
Apr 4, 2018
src/libopensc/card-epass2003.c
Outdated
| @@ -2680,15 +2696,18 @@ epass2003_pin_cmd(struct sc_card *card, struct sc_pin_cmd_data *data, int *tries | |||
|
|
|||
| data->pin1.max_tries = maxtries; | |||
| } | |||
|
|
|||
| return r; | |||
| // return r; | |||
There was a problem hiding this comment.
I think you accidentally added a comment here, because you're running into external_key_auth, when SC_PIN_CMD_GET_INFO is requested...
|
the rest of the code looks good, though |
|
@FeitianSmartcardReader have you looked at the comment above? |
|
@frankmorgner Sorry, just back from holiday, check now and reply you later, thanks |
Add comments for remove line 2700
|
Thanks! Could you fill in the checklist above with the test status? |
|
@frankmorgner The windows minidriver I haven't test, if need, I should can do test tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check of ec and rsa
condition check of rsa
adjust code, improve condition check of data->cmd.
Checklist