Add support for fixed-length pinpad readers #1288
Conversation
Some pinpad readers have to be told the length of the PIN to accept. OpenPGP has a DO for storing the length. This patch reads the and parses the DO if it is properly configued, and supplies it for use for APDUs.
|
How did you test this? Did you test this also without PIN pad? |
|
Your code doesn't compile |
|
Sorry didn't check x86, now compiles :) |
There was a problem hiding this comment.
Looks like your code is a direct translation of gnupg's app-openpgp.c. First, PINPAD_REQUEST is an extension of gnupg, not OpenPGP. It would have been nice if you'd copy over the describing comment as well.
What could be problematic, is that gnupg's code is GPL licensed while OpenSC is LGPL (and historically GPL, as far as I know).
A simpler and yet more powerful (i.e. card-independant) change would be to add a configuration option to the reader section to force a fixed PIN length...
| @@ -44,6 +44,8 @@ | |||
| #include <openssl/sha.h> | |||
| #endif /* ENABLE_OPENSSL */ | |||
|
|
|||
| #define digitp(p) (*(p) >= '0' && *(p) <= '9') | |||
There was a problem hiding this comment.
There is isdigit() in C89.
|
Yep sorry I mentioned it came from there in the issue, I should have restated that here as well, sorry! I did also copy over and modified the comment from there. |
Fixes #1221
Some pinpad readers have to be told the length of the PIN to accept. OpenPGP has a DO for storing the length. This patch reads the and parses the DO if it is properly configued, and supplies it for use for APDUs.