sc-hsm: fixed accessing version info #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had similar patch prepared to submit, since I was running into this issue from time to time. I am not sure about the changes of the numbers, but if it comes in some specification, that these bits should be on these places (not on the last and one before last), I believe this should go in. |
|
By definition, the major and minor number are always encoded in the last two bytes. Older sc-hsm version have a shorter prop_attr, so this will break older cards. |
|
Hmm, I didn't get this definition by reading the specification. Anyway, i changed the parsing so that it hopefully is backward compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1244
Checklist