pkcs11-tool testsuite improvements #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmorgner
requested changes
Sep 14, 2017
| @@ -4847,7 +4847,7 @@ static int encrypt_decrypt(CK_SESSION_HANDLE session, | |||
| return 0; | |||
|
|
|||
| if (EVP_PKEY_size(pkey) > (int)sizeof(encrypted)) { | |||
| fprintf(stderr, "Ciphertext buffer too small\n"); | |||
| printf("Ciphertext buffer too small\n"); | |||
There was a problem hiding this comment.
why print errors on stdout instead of stderr?
There was a problem hiding this comment.
It is not an error, but part of the "testsuite report", which starts on line 4843, does not end with a newline and expects some result to be added (which is in this case "error").
printf(" %s: ", p11_mechanism_to_name(mech_type));
We can go the other way round and print everything on the stderr too. But if part is printed to the first stream and the second part is printed to the second stream, the formatting is undefined.
|
OK, thanks for the clearification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The randomization should not happen for the
RSA_PKCSmechanism, since the data is already filled with ASN1 encoded DigestInfo + SHA1 hash.The second commit improves handling of decryption testcases to get reasonable reports in single stream (not writing first part of line to stdout and the second to stderr) and avoids hard-failures with OAEP mechanisms (
CKR_MECHANISM_PARAM_INVALID).Checklist