CAC issues #1120
Merged
CAC issues #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nized for the lack of other pointers how to recongnize them
frankmorgner
requested changes
Aug 2, 2017
src/libopensc/card-cac.c
Outdated
| if (r == SC_ERROR_INS_NOT_SUPPORTED) { | ||
| /* The CACv1 instruction is not recognized. Try with CACv2 */ | ||
| card->type = SC_CARD_TYPE_CAC_II; | ||
| goto cac2; |
There was a problem hiding this comment.
Please avoid goto for anything else than cleanup. See frankmorgner@1fad8ea for a suggestion.
There was a problem hiding this comment.
Thank you. I probably ran out of creative ideas after hours of debugging. The attached commit should do the job. I will try tomorrow.
2 tasks
metsma
pushed a commit
to metsma/OpenSC
that referenced
this pull request
Dec 6, 2017
* cac: Make the retransmitted APDU valid by restoring the resplen * cac: Check SWs for all the APDUs and report the errors to underlying layers * cac: Fallback from CACv1 to CACv2 when CACv1 instruction is not recognized for the lack of other pointers how to recongnize them * avoid goto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits resolve the following issues in CAC driver:
https://bugzilla.redhat.com/show_bug.cgi?id=1473335
https://bugzilla.redhat.com/show_bug.cgi?id=1473418
This one is not elegant (improvements welcome)
I am able to read this cards certificate, but not do any operations (the card looks like it does not understand VERIFY PIN instructions).
Checklist