Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coolkey] Copy labels from certificate objects to the keys #1088

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

Jakuje
Copy link
Member

@Jakuje Jakuje commented Jul 4, 2017

After some testing by users in Fedora who are using Coolkey applets (or their modifications), we noticed missing labels on the keys. In the underlying structures, they are available only in the certificate objects and for usability reasons it would be good to see them also on the keys, as it was in the old Coolkey module.

This PR goes through the emulated PKCS15 objects and if one is missing a label, it tries to search for the matching certificate and copy the label to that key too.

I was trying to reuse the provided functions by the pkcs15.h, but comments and improvements are welcomed.

@frankmorgner
Copy link
Member

Is the label shown in some meaningful application other than pkcs11-tool?

@Jakuje
Copy link
Member Author

Jakuje commented Jul 10, 2017

I do not have other specific use case where these labels would be visible. But other cards (PIV, ...) have meaningful labels for all the objects so I don't think coolkey should come with empty labels.

@frankmorgner frankmorgner merged commit e069654 into OpenSC:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants