[coolkey] Copy labels from certificate objects to the keys #1088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing by users in Fedora who are using Coolkey applets (or their modifications), we noticed missing labels on the keys. In the underlying structures, they are available only in the certificate objects and for usability reasons it would be good to see them also on the keys, as it was in the old Coolkey module.
This PR goes through the emulated PKCS15 objects and if one is missing a label, it tries to search for the matching certificate and copy the label to that key too.
I was trying to reuse the provided functions by the
pkcs15.h
, but comments and improvements are welcomed.