Dnie better wrapping/unwrapping of the secure apdus #1028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the pull #975 is committed this is the second part that can be added to the DNIe. As I said in the previous issues/pulls the DNIe driver could be improved if the sc_transmit_apdu was called normally. This pull contains the following improvements:
No memory problems detected with valgrind and my tester runs smoothly with the changes (both versions of DNIe). This modification can be seen as the second part of the previous unification to opensc secure messaging (I didn't want to do it before being sure the previous part was integrated).
With this pull the only thing I have in mind that can improve the DNIe driver is transforming the signature key in version 3.0 to always authenticate. But for the moment that part cannot be done. So I have no more pending changes.