-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iso7816_get_response fails if card->max_recv_size == 0 #533
Comments
Thanks for finding this problem. Indeed, I didn't think of this special case. It should effect all cards that use generic commands during initialization without setting the correct transceive lengths (i.e. |
The special value still needs to be handled for commands that are issued during card initialization. This especially concerns T=0 cards that need to use iso_get_response. fixes OpenSC#533 regression of 85b79a3
Could you check if #534 fixes the problem? |
Yes it fixes the problem I had seen with get_response during card matching. It appears that many of these changes were designed to eliminate the existing Would it be better to go back revert some of these changes and go back to the original test for size == 0? On 8/25/2015 7:59 PM, Frank Morgner wrote:
Douglas E. Engert [email protected] |
@dengert #534 does exactly activate all checks for handling From the software engineering point of view I'd actually like to have something differently:
This would make the code more readable overall and it would also solve your problem. However, it would mean to change many card drivers and a lot of testing... I've chosen the easy path over what I think would be the correct way to go. |
@frankmorgner Another issue with the card sizes
Some cards that still use T=0 and need test if the card matches the driver need to do
read the cards default AID. This will require the use of iso7816_get_response before the card's
max_recv_size can be set.
In previous version iso7816.c had:
Current git master has:
The change was introdiced by:
bb92019
A trace shows:
@frankmorgner This looks like another issue with the card sizes.
The text was updated successfully, but these errors were encountered: