MacOS build failure with OpenSSL 3.0 #2967
Comments
|
@metsma did you manage to have a look into this? We can probably ignore the errors or try to fix them (but there is dozens of them). I am always surprised by the macos ci that works in PR but fails on master. Is there something we can make it failing the same way for both of them? Or is it unrelated to the OpenSSL version change? By comparing the logs, I see the macos was updated from 12.6.9 to 12.7.2, but it still works in the PRs. |
|
I will try find time for this. |
|
I did look into, but this requires more in depth knowledge of all OpenSC internals. |
|
Thank you for having a look into that! I agree that some syncing on a specific type would be beneficial. I think most of the internal types is already using size_t so I would propose to use Algorithms or fixed enums should really used that enum number if possible. In other cases, the I started changing some of the stuff, but there is still a lot to go. I thought if you have some insight of what changed. If it is because of the new OpenSSL, clang, mac or something completely independent ... |
|
I think this is related to master builds signed packages and then OpenSCTokenApp is pulled to build. |
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
|
I think the #2993 will fix the master build, but I do not know how to check this in the PR (I tested with the flags locally and in additional specially crafted linux run with clang and these specific flags). I know, its huge, but inputs/reviews are welcomed. |
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix OpenSC#2967
These are exposed by a shorten-64-to-32 warning from clang that is turned
out automatically when building release build for OSX.
They can be also triggered manually with similar configuration like this:
CC=clang CFLAGS=-Wshorten-64-to-32 ./configure && make -j8
Should fix #2967
Problem Description
After merging #2930 changing the macos build to use openssl 3.0, we are getting a new errors:
Trying to run the build locally on linux with this CFLAG results in dozens of more issues after fixing this one (I will try to fix them but it will be probably more work than just simple hotfix so it will likely take some time):
Proposed Resolution
Steps to reproduce
See the latest macos builds in master failing
The text was updated successfully, but these errors were encountered: