Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MS Edge as nss browser #2902

Merged
merged 1 commit into from Oct 18, 2023
Merged

Add MS Edge as nss browser #2902

merged 1 commit into from Oct 18, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2023

Fixes: #2870

  • PKCS#11 module is tested

@Jakuje Jakuje added this to In progress in OpenSC 0.24.0 via automation Oct 17, 2023
@dengert
Copy link
Member

dengert commented Oct 17, 2023

Does MS edge use Mozilla NSS? I don't think so: https://stackoverflow.com/questions/441194/does-microsoft-provides-a-pkcs-11-provider-that-connects-to-its-own-ms-cryptoap

OpenSC provides a "minidriver" for Windows which should be used with Edge. This calls the OpenSC pkcs15 API which does not use PKCS11.

https://learn.microsoft.com/en-us/windows-hardware/drivers/smartcard/smart-card-minidrivers

So IMHO,strstr(basename, "msedge") will never be true.

@metsma
Copy link
Contributor

metsma commented Oct 18, 2023

Yes on linux it does use NSS

@frankmorgner frankmorgner merged commit d847c94 into OpenSC:master Oct 18, 2023
35 of 36 checks passed
OpenSC 0.24.0 automation moved this from In progress to Done Oct 18, 2023
@frankmorgner
Copy link
Member

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

is_nss_browser process name check is brittle and doesn't include Microsoft Edge
4 participants