-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_nss_browser process name check is brittle and doesn't include Microsoft Edge #2870
Comments
We would be happy to detect Edge. If The only reported crash of Firefox (as NSS browser) that is still present in 0.23.0, that I am aware of, is #2419. This is fixed in |
Also note that you may always set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Description
In #2681, a check for the process name was added to check for "chrome", "chromium", and "firefox". As far as I can tell, this is unlikely to cover other Chromium-based browsers like Microsoft Edge ("msedge").
Proposed Resolution
Add other Chromium-based browsers that are available on Linux.
Other context
I was looking at this code because the Microsoft Edge team received a report from a customer that a crash happens in Microsoft Edge when they move to
0.23.0-0.1ubuntu1
from0.20.0-3ubuntu0.1~esm1
. That crash looks like heap corruption and the customer doesn't see the issue in Google Chrome, so I decided to see if there were any clear browser detection code paths. I don't have any smoking gun yet on where the heap corruption is happening, unfortunately.Since #2681 was added after that release, I don't think it's pertinent to the customer-reported problem, but it would presumably cause Chrome vs. Edge behavior differences in 0.24.0, so I'm proactively filing this issue.
The text was updated successfully, but these errors were encountered: