Log.c not adding end of line in many cases in debug log

[dengert]

Problem Description

This should be fixed before release of 0.22.0.

Regression of opensc.debug.log formatting. New line characters are missing in some cases.

Problem appears to be caused by 99656de which dropped log.c lines-147-148 that would add a "\n" if needed.

Logs

For example the first line of debug log now looks like:

P:27245; T:0x139925753395264 07:52:02.170 [opensc-pkcs11] ../../../src/src/libopensc/ctx.c:855:sc_context_create: ===================================P:27245; T:0x139925753395264 07:52:02.170 [opensc-pkcs11] ../../../src/src/libopensc/ctx.c:856:sc_context_create: opensc version: 0.22.0-rc2P:27245; T:0x139925753395264 07:52:02.171 [opensc-pkcs11] ../../../src/src/libopensc/reader-pcsc.c:886:pcsc_init: PC/SC options: connect_exclusive=0 disconnect_action=0 transaction_end_action=0 reconnect_action=0 enable_pinpad=1 enable_pace=1P:27245; T:0x139925753395264 07:52:02.171 [opensc-pkcs11] ../../../src/src/libopensc/reader-pcsc.c:1386:pcsc_detect_readers: called

Where in past it would be 3 lines:

P:27245; T:0x139925753395264 07:52:02.170 [opensc-pkcs11] ../../../src/src/libopensc/ctx.c:855:sc_context_create: ===================================
P:27245; T:0x139925753395264 07:52:02.170 [opensc-pkcs11] ../../../src/src/libopensc/ctx.c:856:sc_context_create: opensc version: 0.22.0-rc2P:27245; T:0x139925753395264 07:52:02.171 [opensc-pkcs11] ../../../src/src/libopensc/reader-pcsc.c:886:pcsc_init: PC/SC options: connect_exclusive=0 disconnect_action=0 transaction_end_action=0 reconnect_action=0 enable_pinpad=1 enable_pace=1
P:27245; T:0x139925753395264 07:52:02.171 [opensc-pkcs11] ../../../src/src/libopensc/reader-pcsc.c:1386:pcsc_detect_readers: called

Proposed Resolution

Revert 99656de
Or add new logic to add a "\n". But without using a buffer this will be difficult.
It might be possible to test if format ends in "\n".