Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not build tools when crucial dependencies are missing #2617

Merged
merged 4 commits into from
Oct 25, 2022
Merged

Do not build tools when crucial dependencies are missing #2617

merged 4 commits into from
Oct 25, 2022

Conversation

xhanulik
Copy link
Contributor

Fixes #2074
This PR adds checking for ENABLE_NOTIFY and ENABLE_OPENPACE macros into Makefile for tools. When the libraries are missing, the tools which are useless without them are not built.

Checklist
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

frankmorgner
frankmorgner requested changes Oct 17, 2022
View reviewed changes
win32/Make.rules.mak Show resolved Hide resolved
@Jakuje
Copy link
Member

Jakuje commented Oct 25, 2022

Thank you for your contribution. Merging.

@Jakuje Jakuje merged commit ec6d7b1 into OpenSC:master Oct 25, 2022
@xhanulik xhanulik mentioned this pull request Oct 31, 2022
Closed
@xhanulik xhanulik deleted the tools branch October 31, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankmorgner frankmorgner frankmorgner requested changes

@Jakuje Jakuje Jakuje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not build empty/useless tools with missing dependencies
3 participants
@xhanulik @Jakuje @frankmorgner