Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not build empty/useless tools with missing dependencies #2074

Closed
Jakuje opened this issue Jul 2, 2020 · 1 comment · Fixed by #2617
Closed

Do not build empty/useless tools with missing dependencies #2074

Jakuje opened this issue Jul 2, 2020 · 1 comment · Fixed by #2617
Labels
good first issue Wishlist

Comments

@Jakuje
Copy link
Member

Jakuje commented Jul 2, 2020

opensc-notify, npa-tool and maybe more tools are built even if crucial dependencies are not met (GUI libraries, openpace, ...). It would be nice to adjust build system to not build these if they are not usable.

Oh... and yes, disabling opensc-notify in this case, would be good from a user's perspective

Originally posted by @frankmorgner in #2069 (comment)
@Jakuje
Copy link
Member Author

Jakuje commented Jan 25, 2022

The npa-tool should be solved partially with de8fa08 (already merged). It still builds, but at least prints an error when it can not do anything else.

@xhanulik xhanulik mentioned this issue Oct 14, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Wishlist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not build tools when crucial dependencies are missing xhanulik/OpenSC
1 participant
@Jakuje