MacOS: master fails to compile with Xcode-10

[mouse07410]

Problem Description

Xcode-10 in file

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/PCSC.framework/Headers/pcsclite.h

defines macro PCSC_API, which is re-defined in src/libopensc/internal-winscard.h.

Proposed Resolution

diff --git a/src/libopensc/internal-winscard.h b/src/libopensc/internal-winscard.h
index 011167dd..ad74dbdb 100644
--- a/src/libopensc/internal-winscard.h
+++ b/src/libopensc/internal-winscard.h
@@ -142,6 +142,7 @@ typedef const SCARD_IO_REQUEST *LPCSCARD_IO_REQUEST;
 #define PCSC_API WINAPI
 #elif defined(USE_CYGWIN)
 #define PCSC_API __stdcall
 #else
+#undef PCSC_API
 #define PCSC_API
 #endif

Actually, the above fix should include guards - Xcode-9 and prior did not seem to define that macro, at least compilation did not fail...

Steps to reproduce

Just try a clean compile, like

$ make distclean
$ ./bootstrap && MacOSX/build

Observe the results.

Logs

. . . . .
  CC       libopensc_la-reader-tr03119.lo
  CC       libopensc_la-card-setcos.lo
In file included from reader-pcsc.c:41:
./internal-winscard.h:146:9: error: 'PCSC_API' macro redefined [-Werror,-Wmacro-redefined]
#define PCSC_API
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/PCSC.framework/Headers/pcsclite.h:51:9: note: 
      previous definition is here
#define PCSC_API extern __attribute__((visibility ("default")))
        ^
1 error generated.
make[3]: *** [libopensc_la-reader-pcsc.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

[mouse07410]

Fixing this problem allows the compilation to proceed, but the build still fails in OpenSC.tokend:

. . . . .
    cd /Users/ur20980/src/OpenSC/OpenSC.tokend
    export LANG=en_US.US-ASCII
    clang -x c++ -arch x86_64 -fmessage-length=119 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -fcolor-diagnostics -stdlib=libstdc++ -Wno-trigraphs -fpascal-strings -Os -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Wunreachable-code -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DLIMITED_SIGNING -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.10 -g -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -iquote /Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/tokend-generated-files.hmap -I/Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/tokend-own-target-headers.hmap -I/Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/tokend-all-target-headers.hmap -iquote /Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/tokend-project-headers.hmap -I/Users/ur20980/src/OpenSC/OpenSC.tokend/build/include -I/Users/ur20980/src/OpenSC/OpenSC.tokend/build/opensc-src -I/Users/ur20980/src/OpenSC/openssl_bin/Library/OpenSC/include -I/Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/DerivedSources/x86_64 -I/Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/DerivedSources -Wmost -Wno-four-char-constants -Wno-unknown-pragmas -F/Users/ur20980/src/OpenSC/OpenSC.tokend/build -Fbuild -DNDEBUG -Os -MMD -MT dependencies -MF /Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/Objects-normal/x86_64/Token.d --serialize-diagnostics /Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/Objects-normal/x86_64/Token.dia -c /Users/ur20980/src/OpenSC/OpenSC.tokend/Tokend/Token.cpp -o /Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/Objects-normal/x86_64/Token.o
warning: include path for stdlibc++ headers not found; pass '-std=libc++' on the command line to use the libc++
      standard library instead [-Wstdlibcxx-not-found]
In file included from /Users/ur20980/src/OpenSC/OpenSC.tokend/Tokend/Token.cpp:29:
In file included from /Users/ur20980/src/OpenSC/OpenSC.tokend/Tokend/Token.h:33:
In file included from /Users/ur20980/src/OpenSC/OpenSC.tokend/build/security_utilities.framework/Headers/osxcode.h:25:
In file included from /Users/ur20980/src/OpenSC/OpenSC.tokend/build/security_utilities.framework/Headers/refcount.h:31:
In file included from /Users/ur20980/src/OpenSC/OpenSC.tokend/build/security_utilities.framework/Headers/threading.h:35:
In file included from /Users/ur20980/src/OpenSC/OpenSC.tokend/build/security_utilities.framework/Headers/utilities.h:32:
In file included from /Users/ur20980/src/OpenSC/OpenSC.tokend/build/security_cdsa_utilities.framework/Headers/cssmbridge.h:32:
In file included from /Users/ur20980/src/OpenSC/OpenSC.tokend/build/security_cdsa_utilities.framework/Headers/cssmerrors.h:31:
/Users/ur20980/src/OpenSC/OpenSC.tokend/build/security_utilities.framework/Headers/errors.h:33:10: fatal error: 
      'exception' file not found
#include <exception>
         ^~~~~~~~~~~


CompileC /Users/ur20980/src/OpenSC/OpenSC.tokend/build/Tokend.build/libtokend.build/Objects-normal/x86_64/SelectionPredicate.o /Users/ur20980/src/OpenSC/OpenSC.tokend/Tokend/SelectionPredicate.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target: libtokend)

The missing file exists where one would expect Xcode C++ headers to reside:

$ find /Applications/Xcode.app -name exception -print
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/exception
$ ll /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/exception
-rw-r--r--  1 root  wheel  9570 Jun 15 14:12 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/exception
$

The fact that OpenSC.tokend is built with libstdc++ seems to be causing this problem.

[bwesterb]

I also hit your first problem. Your patch fixes the problem for me.

[mouse07410]

@bwesterb how did you avoid or fix the second problem? Or are you not using OpenSC.tokend?

[bwesterb]

I didn't hit it when running bootstrap && ./configure && ./make && sudo ./make install. I don't think I use OpenSC.tokend.

[mouse07410]

What OS are you running on? The process your described does not build OpenSC.tokend, and in general is suitable for Linux.

[bwesterb]

macOS Mojave

[mouse07410]

I see. So Safari and Apple Mail (and system components for login, screensaver unlock, etc.) can work with the token regardless, via pivtoken that's included with the OS. And OpenSC supplies the command-line tools, and opensc-pkcs11.so PKCS#11 library that you can point Firefox and Adobe Acrobat at...

[bwesterb]

Actually I only use pkcs11.so to use a yubikey to store my ssh private key.

[frankmorgner]

@mouse07410 please make a PR at https://github.com/OpenSC/OpenSC.tokend

[mouse07410]

@frankmorgner I wish I knew how to fix the tokend build on Mojave (or even with Xcode-10). In fact, that's what stopping me from upgrading my main machine to Mojave right now.

[bwesterb]

c3bef7d fixed the issue for me, thanks!