dtrust-tool: fix memory leak

If `qespin1` and `qespin2` doesn't match, `qespin2` was neither cleared nor freed;
OpenSC · Jun 3, 2024 · 58910ab · 58910ab
1 parent 6ceb50e
commit 58910ab
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/tools/dtrust-tool.c b/src/tools/dtrust-tool.c
@@ -179,7 +179,7 @@ unlock_transport_protection(sc_card_t *card)
 
  if (strcmp(qespin1, qespin2)) {
  fprintf(stderr, "New signature PINs doesn't match.\n");
- goto fail_qespin2;
+ goto fail_qespincmp;
  }
  data.pin1.data = (u8 *)tpin;
  data.pin1.len = strlen(tpin);
@@ -196,6 +196,7 @@ unlock_transport_protection(sc_card_t *card)
  else
  printf("Can't change pin: %s\n", sc_strerror(r));
 
+fail_qespincmp:
  if (qespin2 != NULL) {
  sc_mem_clear(qespin2, qespin2_len);
  free(qespin2);