Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More small track design refactors #22164

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

Gymnasiast
Copy link
Member

@Gymnasiast Gymnasiast commented Jun 12, 2024

This brings some more refactors to the in-memory track design structures. The scope is limited because the code is frankly a lot of spaghetti that needs careful untagliatelleuntangling.

  • Replacement of snake_case with lowerCamelCase
  • Simplification of maze entries (possible now that maze entrances/exit are no longer stored in there)
  • Addition of a "tertiary colour" field for scenery (previously only supported by walls and hidden in the "flags" byte)

Note to tester(s): make sure to test maze designs and designs containing a wall with three colours.

@spacek531
Copy link
Contributor

I will update this as I find more. Wall with 3 colors does not work
image

@Gymnasiast
Copy link
Member Author

Third colour on walls should now be fixed.

Copy link
Contributor

@spacek531 spacek531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works

Copy link
Contributor

@mrmbernardi mrmbernardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided my other comment is addressed, everything else looks good.

@Gymnasiast Gymnasiast added this to the v0.4.12 milestone Jun 14, 2024
@Gymnasiast Gymnasiast merged commit a04b83b into OpenRCT2:develop Jun 14, 2024
22 checks passed
@Gymnasiast Gymnasiast deleted the refactor/more-trackdesign branch June 14, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants