Fix build when using new boost with Ogre. #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a [Parse error at "BOOST_JOIN"] if you're using - for instance - Boost 1.57.0
|
What if we forward declare the types instead and include in the .cpp only? That would fix the parse error too, right? |
|
Indeed it should, moc only runs on the .hpp's as far as I know. |
|
Ok, then I would prefer that solution to keep the number of #ifs to a minimum. |
|
Something like this then? |
ghost
pushed a commit
that referenced
this pull request
Jan 23, 2015
Fix build when using new boost with Ogre.
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Sep 28, 2017
water shader improvements plus rain ripple effect (#452)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a [Parse error at "BOOST_JOIN"] if you're using - for instance - Boost 1.57.0