clone.cpp remove dynamic_cast #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unelsson gave his blessing |
IIRC, osgAnimation is used only for Collada files. |
Yeah, that's why I had @unelsson have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing groundcover cloning I may have found a superfluous operation. osgAnimation Bone and Skeleton derive from osg Node and respect the DEEP_COPY_NODES copy flags we use. Therefore the nodes should be cloned in the same way without this special case. Somehow I have no osgAnimation nodes in my game files and cannot test. Perhaps author @unelsson can chime in if I am on the right track.