Added setting to change the directory screenshots are stored in

[britown88]

Was annoyed that all my screnshots were clogging up my user data path so whipped this up.

Uses boost filesystem for creating directories so should be cross platform and falls back to the user data directory if making the folder fails. I was torn on putting this in the ConfigurationManager because although it thematically fits, it needs the settings string passed into it and returns by-value. This seemed consistent enough with the behavior the configurationmanager already does in the constructor. Let me know if you dont like it there, I'm completely new to this codebase (and also deeply prefer c-style structure)

Tested relative and absolute paths on windows only.

[akortunov]

If I remembered correctly, we avoid to store paths in the settings.cfg due to security/safety reasons (such settings may lead to path traversals, allow to overwrite existing files, etc.).
For same reasons we escape special characters in player's name.

An another issue is absolute paths. They will make settings.cfg not portable across platforms.

[britown88]

yeah i was pretty torn on absolute paths support. We could lock down the feature to just boolean 'store screenshots to a seperate folder in userdata' if that's more comfortable. Depending on y'alls feelings about settings.cfg backward compatibility, I'd even just kill it out of settings and make it the default behavior. Let me know.

The core feature here is having an option to declutter the user data folder.

[Capostrophic]

How about adding a new folder to user's local data directory called "screenshots" to put screenshots there?

It doesn't even need to be optional.

[akortunov]

How about adding a new folder to user's local data directory called "screenshots" to put screenshots there?

A good idea, but it may be not what PR's author wants.

[britown88]

I figured that people would want this feature to be configurable but if not then there's no reason to navel-gaze on this. I've updated the feature to save screenshots in a folder in userdata called screenshots.

[psi29a]

I figured that people would want this feature to be configurable but if not then there's no reason to navel-gaze on this. I've updated the feature to save screenshots in a folder in userdata called screenshots.

I like the cut of your jib.