Enable light sources directly to avoid virtual calls #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcernat
pushed a commit
to davidcernat/openmw
that referenced
this pull request
Nov 21, 2019
davidcernat
pushed a commit
to davidcernat/openmw
that referenced
this pull request
Nov 21, 2019
Resolve merge issues related to CHANGELOG.md * master: Optimize skinning (task #4605) Update changelog Update some comments Set the OpenAL source offset after setting the buffer Make Move and MoveWorld console commands move actors standing on moving object (bug OpenMW#2274) Adding Changelog entry Allow messageboxes arguments to have newline characters (bug #3836) Check for impact immediately when launch a projectile (bug OpenMW#3059) Fix gold count calculation in pickupObject (bug #4604) Correct special case soundgen comparisons Move "land" check earlier Fixes #3681 Play landing sound manually and ignore land soundgen textkeys (bug OpenMW#2256) Make some more optimizations to actor processing loops Fix freeze in getActorsSidingWith Addiong missing "to" word Adding common problems that were previous on the site FAQ Treat <> and << operators as < and >< and >> as > in scripts stage1: priorities for event music and other minor improvements to the music system # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on bzzt's changes.
The
setAssociatedModesis supposed to fill the ModeUsage viagetModeUsage()and apply specified changes to the stateset.Currently we use it to enable light sources.
In theory, we can enable light sources directly via a quite common OSG code pattern to avoid overhead.
As a result, every stateset creation in the LightManager takes about 1 microsecond less time.