Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback needed] Stance switching changes, part II #1428

Merged
5 commits merged into from
Sep 1, 2017

Conversation

akortunov
Copy link
Collaborator

@akortunov akortunov commented Sep 1, 2017

This is a continue of #1405.
But I am not sure if we will fix a new behaviour or revert it.

This PR is for the first case for now.
Summary of changes was made:

  1. Fixed regression - bug #4050
  2. Player is allowed to interrupt attack by using Toggle Weapon key, but only when Attack button is pressed, and actual attack is not triggered yet (starting the down-swing, or releasing the arrow), as Chris Robinson suggested in bug #4051 thread.
  3. Do not allow to equip probes and lockpicks during attack
  4. Do not allow to unequip weapons via inventory during attack
  5. Reset player attack animation when unequip weapon or tool from inventory.

Note: to implement spellcast interrupting, we should check if a "start" key from "spellcast" animation group is played somehow.

@ghost ghost merged commit 7a79ebb into OpenMW:master Sep 1, 2017
@akortunov akortunov deleted the stancechangefixes branch September 3, 2017 14:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant