Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Updates/fixes to FAST.Farm tools #71

Merged
merged 13 commits into from
Oct 16, 2023
Merged

Updates/fixes to FAST.Farm tools #71

merged 13 commits into from
Oct 16, 2023

Conversation

rthedin
Copy link
Collaborator

@rthedin rthedin commented Sep 26, 2023

Improvements to the FAST.Farm case management tool.
Fixes a few bugs and adds a few extra functionality, as listed in discussion #67.

The code from before was based on a lot of `repeat` and `tile`, which
became hard to maintain and fix bugs.
This commit:

- Remove the bool for wake steering sweep, as there is no real use
- Remove completely the `repeat`s and `tile`s, in favor of a more clear
loop over the original cases, adding other options as per sweep
requested
- It is a tad slower, but significantly more clear and easier to
  maintain
@rthedin rthedin marked this pull request as ready for review October 4, 2023 21:52
@rthedin rthedin requested a review from ebranlard October 4, 2023 21:52
@ebranlard
Copy link
Collaborator

This is fine with me. I would still hope that the example file would be an example that oculd be run as part of the Continuous integration (using input files in the data directory of the repo).
Not everything might be "runable" (the FAST.Farm exe will be missing. We could skip some of the checks by providing a fake BTS file generated on the fly using a test flag.

@rthedin
Copy link
Collaborator Author

rthedin commented Oct 4, 2023

I haven't forgotten about it. That is still on my to-do list. Ideally, the general workflow structure of this tool need to be changed before we can properly do that though. And also note that what part of this code does is create the directory structure needed and copy/move files around (including a bunch of symlinks). Another detail is that unfortunately some details are still hard-coded for unix (ln being one of them for example). I'm not familiar enough with these tests running as part of the continuous integration to know if this is feasible.

@rthedin rthedin merged commit db4e35b into OpenFAST:dev Oct 16, 2023
4 checks passed
@rthedin rthedin deleted the f/ff_fixes branch October 16, 2023 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants