Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Changes on FAST Farm case creation pull request #64

Closed
wants to merge 3 commits into from
Closed

Changes on FAST Farm case creation pull request #64

wants to merge 3 commits into from

Conversation

MYMahfouz
Copy link

I have used the pull request #56 as a basis and updated it to include the following:

  • Windows batch files.
  • Accept .dll controllers
  • Create Mann turbulent boxes that are used in the simulation.
  • Added a floating flag to include HydroDyn and MoorDyn.

I am planning to make more changes to include:

  • Fast Farm batch files including an option for OMP.
  • Option to add intial condition according to the wind direction and wind speed.
  • Adding wave height and Tp to the case creation.

I hope this helps. Thanks for creating the library.

BR,
Youssef

ebranlard and others added 3 commits January 13, 2023 03:55
Merging dev into main after OpenFAST 3.4 release
changes to create window bat files and include Mann turbulence box windfields
create bat files for windows and add Mann turbulence box
@MYMahfouz MYMahfouz changed the base branch from main to dev June 2, 2023 10:52
@rthedin
Copy link
Collaborator

rthedin commented Jun 21, 2023

Dear Youssef,
Thanks for your contribution. I see you created a Mann box case creation class, which is indeed an useful addition. However, the other files are difficult to track your changes, since it is showing the entire file as modified. Your commits have over 3000 lines added which isn't really the case. Can you pull the latest from dev, add your changes, and submit a new PR containing cleaner commits?

@SWE-UniStuttgart SWE-UniStuttgart closed this by deleting the head repository Jun 21, 2023
@MYMahfouz
Copy link
Author

Dear Regis,

I have created a new PR as you suggested. Sorry for the mess. I am not an expert in using github.

Thank you for creating this in the first place. It made my life much easier and it was easy for me to add functions on top.

BR,
Youssef

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants