Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD15 converter for OF 3.0 to OF 4.0 leaves AFAeroMod comments #16

Open
andrew-platt opened this issue Jun 12, 2024 · 1 comment
Open

Comments

@andrew-platt
Copy link
Collaborator

In the AD15 update for OpenFAST v4.0.0, the AFAeroMod option was replaced with the UA_Mod option (in combination with other options). However, when using the converter, comments may still contain AFAeroMod in the comment. For example, the following comment (line 10) is left as:
False CavitCheck - Perform cavitation check? (flag) [AFAeroMod must be 1 when CavitCheck=true]
but should be changed to
False CavitCheck - Perform cavitation check? (flag) [UA_Mod must be 0 when CavitCheck=true]

I took a look at the converter, but don't know python well enough to address this issue and make a PR.

@rthedin
Copy link
Collaborator

rthedin commented Jun 12, 2024

While this isn't complicated, it will only make sense for OpenFAST v > 4.0.0. Should we add tags to the openfast_toolbox releases as well? Old toolbox had tags and it was easier to match openfast and python-toolbox. See #7. This way we could add the appropriate comment to each tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants