Fix restart file index and nc write #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR still needed? @deslaughter, or is this covered in your fix for FSI coupling? |
|
@ndevelder PR #2365, merged into @gantech I don't understand the change in this PR, does it look right to you? |
|
I'm pretty sure this is important for properly indexing the restart files, using "turb_id" as set in the input file as opposed to the index pulled out from the turbines glob. I do have these lines with this change in my current_fsi branch that we've been using. |
deslaughter
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the restart of fsi simulations from precursor when there are multiple separate turbines (and hoping this contributes to being able to restart multiple turbines)